Fix: allow dismissing photo picker on macOS when Photos library is empty#508
Open
stakeswky wants to merge 1 commit intokeepassium:masterfrom
Open
Fix: allow dismissing photo picker on macOS when Photos library is empty#508stakeswky wants to merge 1 commit intokeepassium:masterfrom
stakeswky wants to merge 1 commit intokeepassium:masterfrom
Conversation
|
|
…pty (keepassium#507) On Mac Catalyst, PHPickerViewController defaults to isModalInPresentation = true, which prevents dismissal via Escape or clicking outside the sheet. When the Photos library is empty, the picker shows no cancel button, trapping the user. Set isModalInPresentation = false on Mac Catalyst so the sheet can always be dismissed interactively. Also fix swapped extension conformance labels (PHPickerViewControllerDelegate and UIAdaptivePresentationControllerDelegate were on the wrong extensions).
stakeswky
force-pushed
the
fix/507-photo-picker-dismiss
branch
from
e184a5f to
658ed1c
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507
Problem: On Mac Catalyst, when the user's Photos library is empty, the
PHPickerViewControllerhas no cancel button andisModalInPresentationdefaults totrue, preventing dismissal via Escape or clicking outside the sheet. The user is trapped and must force-quit.Fix: Set
isModalInPresentation = falseon Mac Catalyst so the picker sheet can always be dismissed interactively (Escape key or clicking outside).Also corrects swapped extension conformance labels —
PHPickerViewControllerDelegateandUIAdaptivePresentationControllerDelegatewere on the wrong extensions (no behavioral change, just correctness).