Skip to content

Check version in vcpkg.json and appstream XML well-formedness, add translator listing #12968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phoerious merged 2 commits into from
Jan 18, 2026
Merged

Check version in vcpkg.json and appstream XML well-formedness, add translator listing #12968

phoerious merged 2 commits into from
Jan 18, 2026
+116 −85

Conversation

@phoerious
Copy link
Member

@phoerious phoerious commented Jan 17, 2026 •
edited
Loading

  • Adds check to the release-tool for the version number in the vcpkg manifest and for well-formedness of the AppStream XML file.
  • Moves the Transifex translator listing utility into the release-tool as a new i18n subcommand.

Type of change

  • ✅ New feature (change that adds functionality)

@phoerious phoerious added this to the v2.7.12 milestone Jan 17, 2026
@phoerious phoerious added build system pr:backport-pending Pull request to be backported labels Jan 17, 2026
@phoerious phoerious requested a review from droidmonkey January 17, 2026 13:50
@phoerious phoerious force-pushed the feature/release-tool-validations branch from e45577e to 84dfecf Compare January 17, 2026 13:51
@phoerious phoerious force-pushed the feature/release-tool-validations branch from 84dfecf to 3cfd143 Compare January 17, 2026 13:56
@phoerious phoerious changed the title Check version in vcpkg.json and appstream XML well-formedness Check version in vcpkg.json and appstream XML well-formedness, add translator listing Jan 17, 2026
@phoerious phoerious force-pushed the feature/release-tool-validations branch 2 times, most recently from 05d33f4 to ac01e58 Compare January 17, 2026 16:21
@phoerious phoerious force-pushed the feature/release-tool-validations branch from ac01e58 to 3491924 Compare January 17, 2026 16:34
@codecov
Copy link

codecov bot commented Jan 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.41%. Comparing base (b370aed) to head (3491924).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #12968   +/-   ##
========================================
  Coverage    64.41%   64.41%           
========================================
  Files          378      378           
  Lines        39877    39877           
========================================
+ Hits         25684    25685    +1     
+ Misses       14193    14192    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@phoerious phoerious merged commit 5bd42c4 into develop Jan 18, 2026
12 checks passed
@phoerious phoerious deleted the feature/release-tool-validations branch January 18, 2026 15:45
phoerious added a commit that referenced this pull request Jan 18, 2026
@phoerious
Check version in vcpkg.json and appstream XML well-formedness, add tr…
55b4e8e 
…anslator listing (#12968)

* Check version in vcpkg.json and appstream XML well-formedness

* Move translator list utility to release-tool
@phoerious phoerious mentioned this pull request Jan 18, 2026
Open
@phoerious phoerious added pr: backported Pull request backported to previous release and removed pr:backport-pending Pull request to be backported labels Jan 18, 2026
pull bot pushed a commit to lucienlmy/keepassxc that referenced this pull request Jan 18, 2026
@phoerious @pull
Check version in vcpkg.json and appstream XML well-formedness, add tr…
d762693 
…anslator listing (keepassxreboot#12968)

* Check version in vcpkg.json and appstream XML well-formedness

* Move translator list utility to release-tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees

No one assigned

Labels

build system pr: backported Pull request backported to previous release

Projects

None yet

Milestone

v2.7.12

Development

Successfully merging this pull request may close these issues.

3 participants

@phoerious @droidmonkey