-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: open alert url encoding #4501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Adilbek Kangerey <[email protected]>
|
@00041275 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shahargl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@00041275 there is a unit test that keep failing: |
shahargl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see test failing
FAILED tests/test_alert_dto.py::test_alert_dto_url_encoding - AssertionError: assert AnyHttpUrl('h...al%5D-Down', ) == '[https://plat...ernal%5D-Down](https://plat...ernal]-down/)'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4501 +/- ##
===========================================
+ Coverage 31.11% 46.64% +15.52%
===========================================
Files 93 164 +71
Lines 10445 16728 +6283
===========================================
+ Hits 3250 7802 +4552
- Misses 7195 8926 +1731 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@00041275 is this still relevant? can you fix the failing test? |
yes, i will check it |
|
@00041275 hey! Any update? we usually do not like keeping stale PR's. if you want we can close and you will reopen when its ready? |
|
Tests are still failing. Closing this for now until we fix it. cc @tuantran0910 |
close #4422