Skip to content

Conversation

@00041275
Copy link
Contributor

@00041275 00041275 commented Apr 10, 2025

close #4422

Signed-off-by: Adilbek Kangerey <[email protected]>
@vercel
Copy link

vercel bot commented Apr 10, 2025

@00041275 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 10, 2025
@00041275 00041275 changed the title Update alert.py open alert url encoded Apr 10, 2025
@talboren talboren changed the title open alert url encoded fix: open alert url encoding Apr 10, 2025
@vercel
Copy link

vercel bot commented Apr 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2025 10:26am

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 12, 2025
@shahargl shahargl self-requested a review April 12, 2025 10:24
@shahargl
Copy link
Member

@00041275 there is a unit test that keep failing:

FAILED tests/test_alert_dto.py::test_alert_dto_url_encoding - AssertionError: assert AnyHttpUrl('h...al%5D-Down', ) == '[https://plat...ernal%5D-Down](https://plat...ernal]-down/)'

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see test failing

FAILED tests/test_alert_dto.py::test_alert_dto_url_encoding - AssertionError: assert AnyHttpUrl('h...al%5D-Down', ) == '[https://plat...ernal%5D-Down](https://plat...ernal]-down/)'

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Apr 12, 2025
@codecov
Copy link

codecov bot commented Apr 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.64%. Comparing base (a33c34f) to head (e481fdf).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/models/alert.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4501       +/-   ##
===========================================
+ Coverage   31.11%   46.64%   +15.52%     
===========================================
  Files          93      164       +71     
  Lines       10445    16728     +6283     
===========================================
+ Hits         3250     7802     +4552     
- Misses       7195     8926     +1731     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@talboren
Copy link
Member

@00041275 is this still relevant? can you fix the failing test?

@00041275
Copy link
Contributor Author

@00041275 is this still relevant? can you fix the failing test?

yes, i will check it
please wait

@shahargl
Copy link
Member

@00041275 hey! Any update? we usually do not like keeping stale PR's. if you want we can close and you will reopen when its ready?

@talboren
Copy link
Member

Tests are still failing. Closing this for now until we fix it. cc @tuantran0910

@talboren talboren closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: open alert url encoded

3 participants