Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt region queries to work with NRAO TAP service #24

Merged
merged 1 commit into from
May 30, 2024

Conversation

jjtobin
Copy link

@jjtobin jjtobin commented May 30, 2024

OK, this should be created properly.

For the moment, I just copied tapsql.py form alma and edited the _gen_pos_sql function. The remainder are unchanged for the moment.

@keflavich keflavich merged commit 4ea05c8 into keflavich:nrao_2024 May 30, 2024
1 check failed
@keflavich
Copy link
Owner

Did you also modify _gen_pos_sql? I swear I saw a version in which you had included a new tapsql.py in nrao/, but that wasn't in this commit.

@jjtobin
Copy link
Author

jjtobin commented May 30, 2024

I forgot to do a git add to include the file, will do a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants