Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Default Value Handling in Configuration Files #39

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

keisuke-yanagisawa
Copy link
Owner

This pull request refactors the approach to handling default values in configuration files.

Previously, default values were filled in after the configuration file was loaded, leaving blank fields to be completed.
The new approach initializes the configuration with default values first, which are then overwritten by the values from the loaded configuration file.
This change simplifies the configuration process and improves code maintainability.


この修正は、設定ファイルのデフォルト値の設定の仕方を変更したものになります。

当初は、設定ファイルを読み込んだ後に、空欄部分を埋めるという方式でした。
今回の修正により、まずデフォルト値を設定し、読み込んだ設定ファイルでそのデフォルト値を上書きするという方法に変更しました。
これにより、デフォルト値の理解や追加がしやすくなったと期待します。

@keisuke-yanagisawa keisuke-yanagisawa merged commit 33cb3c2 into main Aug 16, 2024
1 check passed
@keisuke-yanagisawa keisuke-yanagisawa deleted the yaml_default branch August 16, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant