Add ios16 compatibility and improve scrolling handling #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borsosbe
commented
Oct 9, 2022
•
borsosbe
commented
- change MarkdownUI final class to struct because of swiftUI (iOS 16) add WKNavigationDelegate didFinishNavigation
- delegate to handle show markdown flow, it is cleaner and more reliable than waiting 0.3 seconds on MarkdownView. there were cases when evaluateJavaScript() threw errors because of a too-early call
- change isScrollingEnabled to true, now it only starts to scroll horizontally when the content is larger, vertical scrolling not affected by this so it's more convenient that way
change MarkdownUI final class to struct because of swiftUI (iOS 16) add WKNavigationDelegate didFinishNavigation delegate to handle show markdown flow, it is cleaner and more reliable than waiting 0.3 seconds on MarkdownView. there were cases when evaluateJavaScript() threw errors because of a too-early call change isScrollingEnabled to true, now it only starts to scroll horizontally when the content is larger, vertical scrolling not effected by this so its more convenient that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.