update #131: Make dashmap optional. #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can activate the dashmap implementation by activating the feature flag `performance` in your `Cargo.toml` file. This will cause an additional usage of dashmap. Alternatively, you may compile directly with ``` cargo build --features performance ```
bikeshedder
suggested changes
Jan 25, 2025
Owner
|
@mrtryhard sorry I didn't see this until now! I can review this this week. |
Owner
|
Thanks @mrtryhard and @bikeshedder ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #131, I gave a shot at making
dashmapoptional.You can activate the
dashmapimplementation by activating the feature flagperformancein yourCargo.tomlfile. This will cause an additional usage ofdashmap.Alternatively, you may compile directly with
Let me know if you want to name the feature differently or if there are better ways to approach this.