i18n-embed-fl: check args on MessageReference #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `FluentLanguageLoader::with_fluent_message_and_bundle()`. This method functions like `with_fluent_message()`, but it also returns the `FluentBundle` which owns the message. This addition permits the closure to resolve `MessageReference` and to retrieve other messages on the same bundle.
The `fl!()` macro checks that all assigned arguments exist on
the message in question. But fluent messages can also refer to
other messages, and those messages can also have arguments.
```ftl
hello = Hello { to-you }
to-you = to you, {$name}!
```
Previous versions of the macro could not check arguments on
`MessageReference`s since it had no way to resolve them.
Bring the owning `FluentBundle` into scope so that message
references can be resolved. Some unnecessary generics on the
recursive functions are made concrete.
This patch requires an update to i18-embed for new API.
cbs228
commented
Apr 5, 2025
| .map(|m| m.value()) | ||
| .map(|p| args_from_pattern(p, bundle, args)); | ||
| } | ||
| _ => {} |
Contributor
Author
There was a problem hiding this comment.
Should we go ahead and match this enum exhaustively? The source enum is not marked #[non_exhaustive], which means that any additions on fluent's part can be considered breaking. Making our match exhaustive will detect any future additions to the AST with breakage here.
Owner
Contributor
Author
|
Hello @kellpossible, can you assign a reviewer for this PR? |
Owner
|
Hi @cbs228 sorry I didn't see this until now! (Email notifications never seem to work for me, until someone comments), I'd be happy to review this, this coming week. |
kellpossible
approved these changes
Apr 14, 2025
Owner
|
Thanks @cbs228 this is a significant contribution! |
Owner
|
@cbs228 I published a new release with this change |
Contributor
Author
|
Thanks, I appreciate the new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fl!()macro checks that all assigned arguments exist on the message in question. But fluent messages can also refer to other messages, and those messages can also have arguments.hello = Hello { to-you } to-you = to you, {$name}!Previous versions of
fl!()would not permit thenameargument to be bound.Resolving references to other messages requires access to the owning
FluentBundle. A variety of alternatives for granting this access are discussed in #144. This PR adds a new public API function,FluentLanguageLoader::with_fluent_message_and_bundle(), which passes both:to a closure.
With this new capability,
fl!macro is updated to properly supportMessageReference.This is an API-enhancing change for
i18n-embedand a bugfix fori18n-embed-fl.Closes #144.