Skip to content

Fix typo in I18nConfigError variant (breaking change) #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo in I18nConfigError variant (breaking change) #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion i18n-config/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
#[error("Cannot deserialize toml file {0:?} because {1}.")]
CannotDeserializeToml(PathBuf, basic_toml::Error),
#[error("Cannot parse i18n configuration file {0:?} because {1}.")]
CannotPaseI18nToml(PathBuf, String),
CannotParseI18nToml(PathBuf, String),
#[error("There is no i18n configuration file present for the crate {0}.")]
NoI18nConfig(String),
#[error("The \"{0}\" is required to be present in the i18n configuration file \"{1}\"")]
Expand Down Expand Up @@ -86,7 +86,7 @@
pub i18n_config: Option<I18nConfig>,
}

impl<'a> Crate<'a> {

Check warning on line 89 in i18n-config/src/lib.rs

View workflow job for this annotation

GitHub Actions / Clippy 

warning: elided lifetime has a name
   --> i18n-config/src/lib.rs:155:58
    |
89  | impl<'a> Crate<'a> {
    |      -- lifetime `'a` declared here
...
155 |     pub fn active_config(&'a self) -> Result<Option<(&'a Crate, &'a I18nConfig)>, I18nConfigError> {
    |                                                          ^^^^^ this elided lifetime gets resolved as `'a`

Check warning on line 89 in i18n-config/src/lib.rs

View workflow job for this annotation

GitHub Actions / Clippy 

warning: elided lifetime has a name
   --> i18n-config/src/lib.rs:145:29
    |
89  | impl<'a> Crate<'a> {
    |      -- lifetime `'a` declared here
...
145 |     ) -> Result<Option<(&'a Crate, &'a I18nConfig)>, I18nConfigError> {
    |                             ^^^^^ this elided lifetime gets resolved as `'a`
    |
    = note: `#[warn(elided_named_lifetimes)]` on by default

Check warning on line 89 in i18n-config/src/lib.rs

View workflow job for this annotation

GitHub Actions / Clippy 

warning: elided lifetime has a name
   --> i18n-config/src/lib.rs:155:58
    |
89  | impl<'a> Crate<'a> {
    |      -- lifetime `'a` declared here
...
155 |     pub fn active_config(&'a self) -> Result<Option<(&'a Crate, &'a I18nConfig)>, I18nConfigError> {
    |                                                          ^^^^^ this elided lifetime gets resolved as `'a`

Check warning on line 89 in i18n-config/src/lib.rs

View workflow job for this annotation

GitHub Actions / Clippy 

warning: elided lifetime has a name
   --> i18n-config/src/lib.rs:145:29
    |
89  | impl<'a> Crate<'a> {
    |      -- lifetime `'a` declared here
...
145 |     ) -> Result<Option<(&'a Crate, &'a I18nConfig)>, I18nConfigError> {
    |                             ^^^^^ this elided lifetime gets resolved as `'a`
    |
    = note: `#[warn(elided_named_lifetimes)]` on by default
/// Read crate from `Cargo.toml` i18n config using the
/// `config_file_path` (if there is one).
pub fn from<P1: Into<PathBuf>, P2: Into<PathBuf>>(
Expand Down Expand Up @@ -142,7 +142,7 @@
/// otherwise return None.
pub fn parent_active_config(
&'a self,
) -> Result<Option<(&'a Crate, &'a I18nConfig)>, I18nConfigError> {

Check warning on line 145 in i18n-config/src/lib.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

elided lifetime has a name
match self.parent {
Some(parent) => parent.active_config(),
None => Ok(None),
Expand All @@ -152,7 +152,7 @@
/// Identify the config which should be used for this crate, and
/// the crate (either this crate or one of it's parents)
/// associated with that config.
pub fn active_config(&'a self) -> Result<Option<(&'a Crate, &'a I18nConfig)>, I18nConfigError> {

Check warning on line 155 in i18n-config/src/lib.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

elided lifetime has a name
debug!("Resolving active config for {0}", self);
match &self.i18n_config {
Some(config) => {
Expand Down
Loading