Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JSON data into Python files #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ipmb
Copy link

@ipmb ipmb commented Oct 31, 2023

I'm not sure if this is something you want, but it was what got the tests passing for me.

Python packages are weird about installing non-Python files. It requires jumping through some extra hoops in setup.py and MANIFEST.in. It's a pain, so this route seemed easier.

🎉

$ pytest
=================================== test session starts ===================================
platform linux -- Python 3.9.18, pytest-7.3.1, pluggy-1.0.0
rootdir: /home/pete/projects/airpy/airPy
collected 21 items

airpy/tests/test_generate_config.py ....                                            [ 19%]
airpy/tests/test_metric_utils.py ...                                                [ 33%]
airpy/tests/test_processor_modules.py .....                                         [ 57%]
airpy/tests/test_run_airpy.py ..                                                    [ 66%]
airpy/tests/test_utils.py .......                                                   [100%]

=================================== 21 passed in 12.96s ===================================

The JSON data won't be installed with the Python package without jump
through some extra hoops in `setup.py`. It's a pain to do there, so this
makes them Python objects upfront.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant