Prefer Object.hasOwnProperty for additional browser support
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping support for older browsers by reverting the change to `Object.hasOwn` and disabling the eslint rule for the project. Fixes: #150
|
🎉 This PR is included in version 6.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
No worries! Thanks for being so quick and responsive as a maintainer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping support for older browsers by reverting the change to
Object.hasOwnand disabling the eslint rule for the project.Fixes: #150
What: Revert back to using
Object.hasOwnPropertyinstead ofObject.hasOwnWhy:
Object.hasOwnis still unsupported by some older legacy browsers that were supported before this change.How: Reverted back the two changed lines and disabled the
prefer-object-has-ownin the eslint config (could also do this line-by-line, but this prevents it from accidentally being re-introduced in the project).Checklist: