add labels for both new and passed-in registry paths #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralph-tice
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
we probably should start bumping
Line 4 in e782ee1
or at least update it to match the tags we've been creating, not sure
| m.reg.Unregister(name("NewSampleRate")) | ||
| m.reg.Unregister(name("RateLimitDrops")) | ||
| m.reg.Unregister(name("BytesSent")) | ||
| m.reg.Unregister("client_Total") |
I don't know. Not sure who else uses this library and am trying to be as minimally invasive as possible. Perhaps to a fault lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternate path added here #26 which enabled creating metrics from a predefined registry did not add the extra labels to the metrics.
This PR unifies both paths to explicitly define metric labels during creation rather than passing in the
Extrasmap to theOpenHTTPTSDBWithConfigcall.