Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Commit

Permalink
chore: Remove ingress, cleanup helm chart (#309)
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Kreuzberger <[email protected]>
  • Loading branch information
christian-kreuzberger-dtx authored May 18, 2022
1 parent 5e35109 commit aac5014
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 102 deletions.
6 changes: 3 additions & 3 deletions chart/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: prometheus-service
description: A Helm chart for Kubernetes
description: A Helm chart for Keptn's prometheus-service

# A chart can be either an 'application' or a 'library' chart.
#
Expand All @@ -15,10 +15,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
version: 0.0.0-dev

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.7.1"
appVersion: "0.0.0-dev"
32 changes: 10 additions & 22 deletions chart/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,22 +1,10 @@
1. Get the application URL by running these commands:
{{- if .Values.ingress.enabled }}
{{- range $host := .Values.ingress.hosts }}
{{- range .paths }}
http{{ if $.Values.ingress.tls }}s{{ end }}://{{ $host.host }}{{ .path }}
{{- end }}
{{- end }}
{{- else if contains "NodePort" .Values.service.type }}
export NODE_PORT=$(kubectl get --namespace {{ .Release.Namespace }} -o jsonpath="{.spec.ports[0].nodePort}" services {{ include "prometheus-service.fullname" . }})
export NODE_IP=$(kubectl get nodes --namespace {{ .Release.Namespace }} -o jsonpath="{.items[0].status.addresses[0].address}")
echo http://$NODE_IP:$NODE_PORT
{{- else if contains "LoadBalancer" .Values.service.type }}
NOTE: It may take a few minutes for the LoadBalancer IP to be available.
You can watch the status of by running 'kubectl get --namespace {{ .Release.Namespace }} svc -w {{ include "prometheus-service.fullname" . }}'
export SERVICE_IP=$(kubectl get svc --namespace {{ .Release.Namespace }} {{ include "prometheus-service.fullname" . }} --template "{{"{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}"}}")
echo http://$SERVICE_IP:{{ .Values.service.port }}
{{- else if contains "ClusterIP" .Values.service.type }}
export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "prometheus-service.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}")
export CONTAINER_PORT=$(kubectl get pod --namespace {{ .Release.Namespace }} $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
echo "Visit http://127.0.0.1:8080 to use your application"
kubectl --namespace {{ .Release.Namespace }} port-forward $POD_NAME 8080:$CONTAINER_PORT
{{- end }}
Thanks for deploying Keptn's prometheus-service!

You can find more information on the following pages:

* https://github.com/keptn-contrib/prometheus-service
* https://keptn.sh/docs/0.15.x/monitoring/prometheus/install/

IMPORTANT: You must apply below manifest (contains role-binding for prometheus) in order for prometheus-service to be able to communicate with Prometheus:

kubectl -n monitoring apply -f https://raw.githubusercontent.com/keptn-contrib/prometheus-service/{{ .Chart.Version }}/deploy/role.yaml
61 changes: 0 additions & 61 deletions chart/templates/ingress.yaml

This file was deleted.

19 changes: 3 additions & 16 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ image:
# Overrides the image tag whose default is the chart appVersion.
tag: ""

# Prometheus specific configuration
prometheus:
namespace: "monitoring" # K8s namespace where prometheus is installed
namespace_am: "monitoring" # K8s namespace where prometheus-alertmanager is installed
Expand All @@ -28,6 +29,7 @@ distributor:
queueGroup:
enabled: true # Enable connection via Nats queue group to support exactly-once message processing

# Note: Remote Control Plane is currently not supported by prometheus-service - please keep this setting disabled
remoteControlPlane:
enabled: false # Enables remote execution plane mode
api:
Expand Down Expand Up @@ -66,22 +68,6 @@ service:
type: ClusterIP
port: 8080

ingress:
enabled: false
className: ""
annotations: {}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
hosts:
- host: chart-example.local
paths:
- path: /
pathType: ImplementationSpecific
tls: []
# - secretName: chart-example-tls
# hosts:
# - chart-example.local

resources: # Resource limits and requests
limits:
cpu: 500m
Expand All @@ -90,6 +76,7 @@ resources: # Resource limits and requests
cpu: 50m
memory: 32Mi

# Note: We don't recommend turning on auto-scaling
autoscaling:
enabled: false
minReplicas: 1
Expand Down

0 comments on commit aac5014

Please sign in to comment.