Skip to content

Fix functional model output type after deserialization #20120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

shkarupa-alex
Copy link
Contributor

Fix #20119

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.32%. Comparing base (816d219) to head (7c80de5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20120      +/-   ##
==========================================
- Coverage   79.32%   79.32%   -0.01%     
==========================================
  Files         501      501              
  Lines       46983    46990       +7     
  Branches     8660     8665       +5     
==========================================
+ Hits        37268    37273       +5     
- Misses       7968     7969       +1     
- Partials     1747     1748       +1     
Flag Coverage Δ
keras 79.17% <100.00%> (-0.01%) ⬇️
keras-jax 62.49% <100.00%> (-0.01%) ⬇️
keras-numpy 57.55% <100.00%> (-0.01%) ⬇️
keras-tensorflow 63.85% <100.00%> (-0.01%) ⬇️
keras-torch 62.53% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR -- please add a unit test to check this case.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 15, 2024
@fchollet fchollet merged commit b421e1f into keras-team:master Aug 15, 2024
6 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

Wrong model outputs type after from_config(get_config())
4 participants