Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.expm1 operation #29358 #21016

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Adarsh-Chaube
Copy link

Hi @rkazants , can you please review this PR

Copy link

google-cla bot commented Mar 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.04%. Comparing base (c877b89) to head (5218c07).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21016      +/-   ##
==========================================
- Coverage   82.45%   80.04%   -2.42%     
==========================================
  Files         562      562              
  Lines       53662    53664       +2     
  Branches     8325     8325              
==========================================
- Hits        44247    42954    -1293     
- Misses       7377     8725    +1348     
+ Partials     2038     1985      -53     
Flag Coverage Δ
keras 79.86% <0.00%> (-2.41%) ⬇️
keras-jax 63.70% <0.00%> (-0.01%) ⬇️
keras-numpy 58.67% <0.00%> (-0.01%) ⬇️
keras-openvino ?
keras-tensorflow 64.15% <0.00%> (-0.01%) ⬇️
keras-torch 63.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 173 to 174
NumpyTwoInputOpsCorrectnessTest::test_where No newline at end of file
NumpyTwoInputOpsCorrectnessTest::test_where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change

@@ -23,7 +23,6 @@ NumpyDtypeTest::test_digitize
NumpyDtypeTest::test_einsum
NumpyDtypeTest::test_empty
NumpyDtypeTest::test_exp2
NumpyDtypeTest::test_expm1
NumpyDtypeTest::test_eye
NumpyDtypeTest::test_flip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also remove NumpyOneInputOpsCorrectnessTest::test_expm1

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix CI failures

Comment on lines +628 to +629
x=get_ov_output(x)
return OpenVINOKerasTensor((ov_opset.exp(x)-1).output(0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not correct. Please check other PRs as example how to decompose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants