-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.expm1 operation #29358 #21016
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21016 +/- ##
==========================================
- Coverage 82.45% 80.04% -2.42%
==========================================
Files 562 562
Lines 53662 53664 +2
Branches 8325 8325
==========================================
- Hits 44247 42954 -1293
- Misses 7377 8725 +1348
+ Partials 2038 1985 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NumpyTwoInputOpsCorrectnessTest::test_where No newline at end of file | ||
NumpyTwoInputOpsCorrectnessTest::test_where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change
@@ -23,7 +23,6 @@ NumpyDtypeTest::test_digitize | |||
NumpyDtypeTest::test_einsum | |||
NumpyDtypeTest::test_empty | |||
NumpyDtypeTest::test_exp2 | |||
NumpyDtypeTest::test_expm1 | |||
NumpyDtypeTest::test_eye | |||
NumpyDtypeTest::test_flip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also remove NumpyOneInputOpsCorrectnessTest::test_expm1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix CI failures
x=get_ov_output(x) | ||
return OpenVINOKerasTensor((ov_opset.exp(x)-1).output(0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not correct. Please check other PRs as example how to decompose
Hi @rkazants , can you please review this PR