-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various numpy_test changes #21020
various numpy_test changes #21020
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mlx #21020 +/- ##
======================================
Coverage ? 72.48%
======================================
Files ? 572
Lines ? 55890
Branches ? 8623
======================================
Hits ? 40513
Misses ? 13431
Partials ? 1946
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is part of #19571 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thank you!
keras/src/ops/numpy_test.py
Outdated
@pytest.mark.skipif( | ||
keras.config.backend() == "mlx", | ||
reason=""" | ||
MLX flush denormal numbers to 0 on GPU resulting in wrong results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep message on a single line.
keras/src/ops/numpy_test.py
Outdated
@pytest.mark.skipif( | ||
keras.config.backend() == "mlx", | ||
reason=""" | ||
MLX flush denormal numbers to 0 on GPU resulting in wrong results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
This PR contains changes to numpy_test.py in order to:
All tests are now successful