Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uses AbstractMesh in distributed_lib #21031

Closed
wants to merge 1 commit into from

Conversation

vedantag17
Copy link

Issue - #21027

Copy link

google-cla bot commented Mar 14, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.51%. Comparing base (d7c5d42) to head (17e428f).

Files with missing lines Patch % Lines
keras/src/backend/jax/distribution_lib.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21031      +/-   ##
==========================================
- Coverage   82.47%   77.51%   -4.97%     
==========================================
  Files         563      563              
  Lines       53818    53816       -2     
  Branches     8347     8347              
==========================================
- Hits        44387    41716    -2671     
- Misses       7389    10140    +2751     
+ Partials     2042     1960      -82     
Flag Coverage Δ
keras 77.36% <0.00%> (-4.93%) ⬇️
keras-jax ?
keras-numpy 58.76% <0.00%> (+<0.01%) ⬆️
keras-openvino 32.71% <0.00%> (+<0.01%) ⬆️
keras-tensorflow 64.12% <0.00%> (+<0.01%) ⬆️
keras-torch 63.84% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hertschuh
Copy link
Collaborator

@vedantag17

I'm going to close this PR as it won't work as-is. Let's follow up in #21027 once we understand better how this is supposed to work.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed/Rejected
Development

Successfully merging this pull request may close these issues.

None yet

4 participants