-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenVINO backend] Support numpy.log10 #21042
[OpenVINO backend] Support numpy.log10 #21042
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21042 +/- ##
=======================================
Coverage 82.47% 82.48%
=======================================
Files 563 563
Lines 53834 53851 +17
Branches 8359 8361 +2
=======================================
+ Hits 44401 44419 +18
+ Misses 7392 7389 -3
- Partials 2041 2043 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fe98688
to
da7754c
Compare
@darshil929, please fix:
|
Sir, I've fixed the log function to properly handle type conversion for integral inputs, similar to the log10 implementation. The test_log is now passing successfully. |
@rkazants |
@darshil929, please force push to avoid my changes. |
be9a941
to
7a9b9a2
Compare
Sir, i have made the changes, all the checks are successful now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fchollet, looks good to me. Recommend to merge.
Hi @fchollet, Could you please merge it, if it looks fine to you? I recommend to merge. Best regards, |
I have added support for numpy.log10 in OpenVINO backend by:
About implementation:
Related to: openvinotoolkit/openvino#29486
cc @rkazants could you please review?