[OpenVINO Backend] Support numpy min operation #21168
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21168 +/- ##
==========================================
- Coverage 82.69% 82.60% -0.09%
==========================================
Files 564 564
Lines 54223 54434 +211
Branches 8424 8456 +32
==========================================
+ Hits 44837 44963 +126
- Misses 7310 7396 +86
+ Partials 2076 2075 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -35,7 +35,6 @@ NumpyDtypeTest::test_max | |||
| NumpyDtypeTest::test_mean | |||
| NumpyDtypeTest::test_median | |||
| NumpyDtypeTest::test_meshgrid | |||
| NumpyDtypeTest::test_min | |||
| NumpyDtypeTest::test_moveaxis | |||
There was a problem hiding this comment.
Please add line with NumpyDtypeTest::test_minimum_python_types
There was a problem hiding this comment.
I have added it. Thank you!
keras/src/backend/openvino/numpy.py
Outdated
| is_empty = False | ||
| for dim in x_shape: | ||
| if dim == 0: | ||
| is_empty = True | ||
| break |
There was a problem hiding this comment.
let us skip is_empty case at all because this is invalid case for which it throws exception.
We assume that x is not empty always.
There was a problem hiding this comment.
please remove is_empty case related code
There was a problem hiding this comment.
I have removed the is_empty case. Thanks
keras/src/backend/openvino/numpy.py
Outdated
|
|
||
| return OpenVINOKerasTensor(result) | ||
|
|
||
| if axis is None and initial is not None: |
There was a problem hiding this comment.
let us handle initial input at the final step. It is the same for all cases.
There was a problem hiding this comment.
Handled at the end. Thanks
keras/src/backend/openvino/numpy.py
Outdated
| if is_bool: | ||
| result = ov_opset.convert(result, Type.boolean).output(0) |
There was a problem hiding this comment.
let us handle it finally. It same for all cases
|
@rkazants Could you please review the changes? |
@rkazants
Closes: openvinotoolkit/openvino#30117