-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Update Torch version everywhere and TF version on GPU. #21732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on synchronizing and upgrading the versions of key deep learning framework dependencies, specifically Torch and TensorFlow, across various environment configurations. The primary goal is to ensure the project benefits from the latest features, performance improvements, and bug fixes provided by these updated library versions, thereby enhancing overall stability and compatibility. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the versions of TensorFlow and PyTorch across various requirement files. The changes are mostly straightforward version bumps. I've identified one potential issue in requirements.txt
where the PyTorch dependency for macOS seems to have been accidentally removed. My review includes a suggestion to fix this.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #21732 +/- ##
===========================================
- Coverage 82.59% 31.66% -50.93%
===========================================
Files 572 572
Lines 58535 58535
Branches 9158 9158
===========================================
- Hits 48345 18538 -29807
- Misses 7853 38760 +30907
+ Partials 2337 1237 -1100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddff6e5
to
3bbf56f
Compare
e0b1683
to
4a55e58
Compare
6a4b251
to
e257167
Compare
8a29ab8
to
42e3d55
Compare
42e3d55
to
d514ad4
Compare
Replacement for #21704