Skip to content

Conversation

james77777778
Copy link
Contributor

Following #21604 and #21734, we no longer need enable_x64 in our tests since all 64bit tests were removed by default.

This PR further cleans up the test suit.

Copy link
Contributor

Summary of Changes

Hello @james77777778, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on streamlining the test suite by eliminating the explicit disabling of JAX's 64-bit mode. Following previous updates that removed 64-bit tests by default, the enable_x64 context manager and related conditional dtype handling logic became redundant. The changes simplify the codebase, making tests cleaner and more maintainable without altering their intended behavior.

Highlights

  • Removal of jax.enable_x64: The explicit usage of jax.enable_x64(False) and its associated context manager jax_disable_x64_context has been removed from various test files. This is a follow-up to previous changes where 64-bit tests were no longer enabled by default.
  • Test Suite Cleanup: The pull request cleans up the test suite by removing unnecessary conditional logic and imports related to disabling JAX's 64-bit mode, simplifying the test code for truediv, add, subtract, multiply, array, divide, floor_divide, maximum, minimum, power, trace, true_divide, and where operations.
  • Simplified Dtype Handling: Conditional logic that downcasted expected dtypes from 64-bit to 32-bit specifically for the JAX backend has been removed, as it is no longer required due to the default 32-bit behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the usage of jax.enable_x64 from the test suite, which is no longer necessary since 64-bit tests have been removed by default. The changes effectively clean up and simplify the tests in keras/src/backend/common/variables_test.py and keras/src/ops/numpy_test.py by removing now-redundant logic for handling 64-bit data types. Additionally, many assertions have been refactored to use the cleaner self.assertDType method, which improves test readability. The changes are correct and well-implemented.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.59%. Comparing base (3137cb0) to head (21ad9ce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21737   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files         572      572           
  Lines       58535    58535           
  Branches     9158     9158           
=======================================
  Hits        48345    48345           
  Misses       7853     7853           
  Partials     2337     2337           
Flag Coverage Δ
keras 82.39% <ø> (ø)
keras-jax 63.19% <ø> (ø)
keras-numpy 57.56% <ø> (ø)
keras-openvino 34.33% <ø> (ø)
keras-tensorflow 63.94% <ø> (ø)
keras-torch 63.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants