-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Remove the unused jax enable_x64
.
#21737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove the unused jax enable_x64
.
#21737
Conversation
Summary of ChangesHello @james77777778, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on streamlining the test suite by eliminating the explicit disabling of JAX's 64-bit mode. Following previous updates that removed 64-bit tests by default, the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the usage of jax.enable_x64
from the test suite, which is no longer necessary since 64-bit tests have been removed by default. The changes effectively clean up and simplify the tests in keras/src/backend/common/variables_test.py
and keras/src/ops/numpy_test.py
by removing now-redundant logic for handling 64-bit data types. Additionally, many assertions have been refactored to use the cleaner self.assertDType
method, which improves test readability. The changes are correct and well-implemented.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21737 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 572 572
Lines 58535 58535
Branches 9158 9158
=======================================
Hits 48345 48345
Misses 7853 7853
Partials 2337 2337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Following #21604 and #21734, we no longer need
enable_x64
in our tests since all 64bit tests were removed by default.This PR further cleans up the test suit.