Skip to content

Conversation

danielenricocahall
Copy link

Per #20910, add eye support for OpenVINO backend.

Copy link
Contributor

Summary of Changes

Hello @danielenricocahall, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the eye function within the OpenVINO backend, directly addressing a reported issue. By implementing this core NumPy array creation operation, the OpenVINO backend's capabilities are enhanced, allowing for the proper generation of identity matrices. This change improves the overall compatibility and robustness of Keras models when utilizing the OpenVINO optimization framework.

Highlights

  • OpenVINO eye function support: Implemented the eye function for the OpenVINO backend, resolving the NotImplementedError previously raised for this operation.
  • Test exclusion removal: Removed NumpyArrayCreateOpsCorrectnessTest::test_eye from the list of excluded tests, indicating that the eye function now passes its correctness test for the OpenVINO backend.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for numpy.eye in the OpenVINO backend. The change is good, but the implementation of eye has some issues with the default data type and inconsistent argument handling. I've provided a suggestion to refactor the function for correctness and clarity.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.59%. Comparing base (3137cb0) to head (b3e7162).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21739   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files         572      572           
  Lines       58535    58540    +5     
  Branches     9158     9159    +1     
=======================================
+ Hits        48345    48350    +5     
  Misses       7853     7853           
  Partials     2337     2337           
Flag Coverage Δ
keras 82.39% <100.00%> (+<0.01%) ⬆️
keras-jax 63.19% <0.00%> (-0.01%) ⬇️
keras-numpy 57.56% <0.00%> (-0.01%) ⬇️
keras-openvino 34.34% <100.00%> (+<0.01%) ⬆️
keras-tensorflow 63.94% <0.00%> (-0.01%) ⬇️
keras-torch 63.48% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants