new-figure-table-extraction - Extract figures from SVG #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfoppiano
force-pushed
the
new-figure-table-models2
branch
from
45da2f2 to
d23c92f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @POST | ||
| public Response getFiguresAndTables( | ||
| @FormDataParam(INPUT) InputStream inputStream) throws Exception { | ||
| return restProcessFiles.getFigures(inputStream); |
Check warning
Code scanning / CodeQL
Information exposure through an error message Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kermitt2 I've started working on the new figure table extraction, but since I have rebased your initial branch on master I created a new branch, to keep the original, in case I break stuff.
From now on, I'm going to do incremental branches, this first PR implemented the SVG parsing and extraction.
There might be some problems with images that are going beyond their actual zone, which I did not find a way to exclude (checking for transparency, etc... did not help in these edge cases - any idea is welcome 👍 ):
(For reference this is Figure 1 SVG):
I'll try to post a few benchmarks for each new implementation so that we can track the progress.
Here are other images (of correctly identified figures) 😄 :