xsk: fix immature cq descriptor production #9241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: bf4807c |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
294560f to
bf9b842
Compare
|
Upstream branch: bf4807c |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/978138=>bpf
branch
from
9b8ea8e to
6b39804
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=978138 expired. Closing PR. |
Eryk reported an issue that I have put under Closes: tag, related to umem addrs being prematurely produced onto pool's completion queue. Let us make the skb's destructor responsible for producing all addrs that given skb used. Commit from fixes tag introduced the buggy behavior, it was not broken from day 1, but rather when xsk multi-buffer got introduced. Introduce a struct which will carry descriptor count with array of addresses taken from processed descriptors that will be carried via skb_shared_info::destructor_arg. This way we can refer to it within xsk_destruct_skb(). To summarize, behavior is changed from: - produce addr to cq, increase cq's cached_prod - increment descriptor count and store it on - (xmit and rest of path...) skb_shared_info::destructor_arg - use destructor_arg on skb destructor to update global state of cq producer to the following: - increment cq's cached_prod - increment descriptor count, save xdp_desc::addr in custom array and store this custom array on skb_shared_info::destructor_arg - (xmit and rest of path...) - use destructor_arg on skb destructor to walk the array of addrs and write them to cq and finally update global state of cq producer Fixes: b7f72a3 ("xsk: introduce wrappers and helpers for supporting multi-buffer in Tx path") Reported-by: Eryk Kubanski <[email protected]> Closes: https://lore.kernel.org/netdev/[email protected]/ Signed-off-by: Maciej Fijalkowski <[email protected]>
|
Upstream branch: bf4807c |
kernel-patches-daemon-bpf
bot
added
new
V2
and removed
changes-requested
V1
V1-ci-fail
labels
kernel-patches-daemon-bpf
bot
force-pushed
the
series/978138=>bpf
branch
from
6b39804 to
23b5395
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=979339 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: xsk: fix immature cq descriptor production
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=978138