Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isn't the position of the trigger refresh button a bit weird? #7217

Closed
Nico-Kestra opened this issue Feb 6, 2025 · 16 comments
Closed

Isn't the position of the trigger refresh button a bit weird? #7217

Nico-Kestra opened this issue Feb 6, 2025 · 16 comments
Assignees
Labels
bug Something isn't working good first issue Great issue for new contributors

Comments

@Nico-Kestra
Copy link
Member

Describe the issue

Enregistrement.de.l.ecran.2025-02-06.a.11.20.37.mov

Environment

  • Kestra Version:0.22.0-SNAPSHOT
  • Operating System (OS/Docker/Kubernetes):
  • Java Version (if you don't run kestra in Docker):
@Nico-Kestra Nico-Kestra added the bug Something isn't working label Feb 6, 2025
@Nico-Kestra Nico-Kestra transferred this issue from kestra-io/docs Feb 6, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Issues Feb 6, 2025
@MilosPaunovic
Copy link
Member

Yup, sure is, and I've just checked in the code, it's a button which refreshes the data for the whole page, not relate to that Backfills column only.

Have an idea on where to put it @Nico-Kestra, maybe we can have a search bar also?

@Nico-Kestra
Copy link
Member Author

Yep like this
Image

@MilosPaunovic MilosPaunovic added the good first issue Great issue for new contributors label Feb 6, 2025
@Pravesh-Sudha
Copy link
Contributor

Is someone working on this issue? If not I would love to.

@MilosPaunovic
Copy link
Member

Go for it @Pravesh-Sudha! 🚀

@MilosPaunovic MilosPaunovic moved this from Backlog to In progress in Issues Feb 6, 2025
@Pravesh-Sudha
Copy link
Contributor

I got one question: How do you run the project locally, I mean to test the changes because docker-compose uses kestra/kestra:latest image (Changes will not be visible in this), and if I navigate to ui dir, and run npm run dev, sure I can seen the frontend but there are some changes that requires data from the API, How to deal with it. I tried docker-compose.override.yml file but it didn't quite work well, got its own issue. After solving this, I can get back on solving the issue.

@Piyush-r-bhaskar
Copy link
Contributor

Hey @Pravesh-Sudha you can follow this easy setup for Frontend: https://kestra.io/docs/getting-started/contributing#setup-kestra-frontend-without-building-the-backend-from-the-source-code

@Pravesh-Sudha
Copy link
Contributor

@Piyush-r-bhaskar Gotcha!!

@Pravesh-Sudha
Copy link
Contributor

I have created the KestraFilter for FlowTrigger.Vue file, but I am confused about the filter, exactly what filter do we need in it @MilosPaunovic ?

Image

@MilosPaunovic
Copy link
Member

@Pravesh-Sudha We need to have only text search, as that is currently the only available parameter (see more on the API reference).

@Pravesh-Sudha
Copy link
Contributor

Till now, I added the KestraFilter on Triggers section, the refresh buttons are working fine as expected, but even after adding some queries related to search, I don't think so, it is working fine, I added a search(trigger) method, based on the API reference:

Image

Image

@MilosPaunovic
Copy link
Member

You'd need to open a PR for me to take a closer look here @Pravesh-Sudha.

@Pravesh-Sudha
Copy link
Contributor

okay Let me do that

@MilosPaunovic
Copy link
Member

Thanks for this @Pravesh-Sudha! 🚀

I've pushed the remaining improvements to the PR itself, but you did a great job on the initial steps.

Closed via #7292.

@github-project-automation github-project-automation bot moved this from In progress to Done in Issues Feb 12, 2025
@Pravesh-Sudha
Copy link
Contributor

Thanks for the appreciation @MilosPaunovic , I saw where I was lacking in the issue, will improve it in future PRs. Also looking forward to writing a blog about Kestra (My experience as a contributor) on Hashnode.
Is it cool to do that?

@MilosPaunovic
Copy link
Member

Yes, absolutely, go for it; looking forward to checking it out! 🚀
You can leave a link to it in a #getting-started channel on our Slack!

@Pravesh-Sudha
Copy link
Contributor

Gotcha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Great issue for new contributors
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants