Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7217: position of refresh button #7244

Closed
wants to merge 1 commit into from

Conversation

Pravesh-Sudha
Copy link
Contributor

What Changes You do and Why?

I changed the RefreshButton.vue file, added a refreshbutton class and gave a margin of 10px so that it looks good.

Earlier the buttons look like this:
Screenshot 2025-02-07 at 5 28 26 PM

After modification, it looks something like this:
Screenshot 2025-02-07 at 5 22 20 PM

I think we should have some gap between the buttons because the screenshot shared by @Nico-Kestra was of the table with search filter but in trigger table, we have separate columns, so it would look weird if we join the two buttons.

It closes #7217 issue

if you desire to change the gap between button, add the following in the style block of RefreshButton.vue file:

.refresh-button + .refresh-button {
    margin-left: 1px;  // Adjust the gap by changing this value.
    }

@MilosPaunovic
Copy link
Member

This is not what we were trying to achieve here - #7217 (comment). We want to introduce KestraFilter search component onto that page.

@MilosPaunovic MilosPaunovic self-requested a review February 7, 2025 12:16
@Pravesh-Sudha
Copy link
Contributor Author

Okay, let me do that then :)

@Pravesh-Sudha Pravesh-Sudha reopened this Feb 7, 2025
@tchiotludo tchiotludo force-pushed the develop branch 2 times, most recently from d2d8668 to 0c3ed3b Compare February 7, 2025 23:48
@Pravesh-Sudha Pravesh-Sudha deleted the feat-patch-1 branch February 11, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Isn't the position of the trigger refresh button a bit weird?
2 participants