frontend: Color the activity nodes for fly and concern #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activity nodes for fly are now colored blue, and concern nodes are colored orange. Request from Jigish Gohil: can you also add code for color coding Blue = Flying, Orange = concern and Green = Rest. Have removed hike and travel as we don't need them and they will give a lot of false positives due to gps always moving around. Signed-off-by: Stef Walter <[email protected]>
|
FYI @cyberorg |
|
Can we do this in a separate layer or overlay? There is value in being able to see age of some node, and activity. Gives us the ability to even filter based on the activity. Layers show up in the top right corner, FYI. |
|
With just 4 types(flying, concern, grounded, offline) don’t think overlay is needed. Let’s just color them as it is for now and revisit in future if there is any need for extra filters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activity nodes for fly are now colored blue, and concern nodes are colored orange.
Request from Jigish Gohil: can you also add code for color coding Blue = Flying, Orange = concern and Green = Rest. Have removed hike and travel as we don't need them and they will give a lot of false positives due to gps always moving around.