Merge branch 'main' of https://github.com/ketanMehtaa/twenty into fix…

…#7826_Improve_menu_mobile_display

.github/workflows/cd-deploy-main.yaml

@@ -5,6 +5,7 @@ on:
       - main
 jobs:
   deploy-main:
+    timeout-minutes: 3
     runs-on: ubuntu-latest
     steps:
       - name: Repository Dispatch

.github/workflows/cd-deploy-tag.yaml

@@ -5,6 +5,7 @@ on:
       - 'v*'
 jobs:
   deploy-tag:
+    timeout-minutes: 3
     runs-on: ubuntu-latest
     steps:
       - name: Repository Dispatch

.github/workflows/ci-chrome-extension.yaml

@@ -3,19 +3,16 @@ on:
   push:
     branches:
       - main
-    paths:
-      - 'package.json'
-      - 'packages/twenty-chrome-extension/**'
+
   pull_request:
-    paths:
-      - 'package.json'
-      - 'packages/twenty-chrome-extension/**'
+
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
 jobs:
   chrome-extension-build:
+    timeout-minutes: 15
     runs-on: ubuntu-latest
     env:
       VITE_SERVER_BASE_URL: http://localhost:3000
@@ -26,7 +23,25 @@ jobs:
         with:
           access_token: ${{ github.token }}
       - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Check for changed files
+        id: changed-files
+        uses: tj-actions/changed-files@v11
+        with:
+          files: |
+            package.json
+            packages/twenty-chrome-extension/**
+             
       - name: Install dependencies
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/yarn-install
       - name: Chrome Extension / Run build
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: npx nx build twenty-chrome-extension
+
+      - name: Mark as Valid if No Changes
+        if: steps.changed-files.outputs.changed != 'true'
+        run: |
+          echo "No relevant changes detected. Marking as valid."  

.github/workflows/ci-e2e.yml.bak

@@ -0,0 +1,52 @@
+name: CI E2E Tests
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - '**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    timeout-minutes: 30
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+      with:
+        fetch-depth: 0
+    - uses: actions/setup-node@v4
+      with:
+        node-version: lts/*
+
+    - name: Check for changed files
+      id: changed-files
+      uses: tj-actions/changed-files@v11
+      with:
+        files: |
+          packages/**
+          playwright.config.ts
+
+    - name: Skip if no relevant changes
+      if: steps.changed-files.outputs.any_changed == 'false'
+      run: echo "No relevant changes detected. Marking as valid."
+
+    - name: Install dependencies
+      if: steps.changed-files.outputs.any_changed == 'true'
+      uses: ./.github/workflows/actions/yarn-install
+    - name: Install Playwright Browsers
+      if: steps.changed-files.outputs.any_changed == 'true'
+      run: yarn playwright install --with-deps
+    - name: Run Playwright tests
+      if: steps.changed-files.outputs.any_changed == 'true'
+      run: yarn test:e2e companies
+    - uses: actions/upload-artifact@v4
+      if: always()
+      with:
+        name: playwright-report
+        path: playwright-report/
+        retention-days: 30

.github/workflows/ci-front.yaml

@@ -3,21 +3,16 @@ on:
   push:
     branches:
       - main
-    paths:
-      - 'package.json'
-      - 'packages/twenty-front/**'
-      - 'packages/twenty-ui/**'
+
   pull_request:
-    paths:
-      - 'package.json'
-      - 'packages/twenty-front/**'
-      - 'packages/twenty-ui/**'
+
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
 jobs:
   front-sb-build:
+    timeout-minutes: 30
     runs-on: ubuntu-latest
     env:
       REACT_APP_SERVER_BASE_URL: http://localhost:3000
@@ -29,48 +24,43 @@ jobs:
           access_token: ${{ github.token }}
       - name: Fetch local actions
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Check for changed files
+        id: changed-files
+        uses: tj-actions/changed-files@v11
+        with:
+          files: |
+            package.json
+            packages/twenty-front/**
+            packages/twenty-ui/**
+
+      - name: Skip if no relevant changes
+        if: steps.changed-files.outputs.any_changed == 'false'
+        run: echo "No relevant changes. Skipping CI."
+
       - name: Install dependencies
+        if: steps.changed-files.outputs.any_changed == 'true' 
         uses: ./.github/workflows/actions/yarn-install
       - name: Diagnostic disk space issue
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: df -h
       - name: Front / Restore Storybook Task Cache
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/task-cache
         with:
           tag: scope:frontend
           tasks: storybook:build
       - name: Front / Write .env
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: npx nx reset:env twenty-front
       - name: Front / Build storybook
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: npx nx storybook:build twenty-front
   front-sb-test:
-    runs-on: ci-8-cores
-    timeout-minutes: 60
-    needs: front-sb-build
-    strategy:
-      matrix:
-        storybook_scope: [pages, modules]
-    env:
-      REACT_APP_SERVER_BASE_URL: http://localhost:3000
-      NX_REJECT_UNKNOWN_LOCAL_CACHE: 0
-    steps:
-      - name: Fetch local actions
-        uses: actions/checkout@v4
-      - name: Install dependencies
-        uses: ./.github/workflows/actions/yarn-install
-      - name: Install Playwright
-        run: cd packages/twenty-front && npx playwright install
-      - name: Front / Restore Storybook Task Cache
-        uses: ./.github/workflows/actions/task-cache
-        with:
-          tag: scope:frontend
-          tasks: storybook:build
-      - name: Front / Write .env
-        run: npx nx reset:env twenty-front
-      - name: Run storybook tests
-        run: npx nx storybook:serve-and-test:static twenty-front --configuration=${{ matrix.storybook_scope }}
-  front-sb-test-shipfox:
+    timeout-minutes: 30
     runs-on: shipfox-8vcpu-ubuntu-2204
-    timeout-minutes: 60
     needs: front-sb-build
     strategy:
       matrix:
@@ -81,37 +71,72 @@ jobs:
     steps:
       - name: Fetch local actions
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Check for changed files
+        id: changed-files
+        uses: tj-actions/changed-files@v11
+        with:
+          files: |
+            packages/twenty-front/**  
+      - name: Skip if no relevant changes
+        if: steps.changed-files.outputs.any_changed == 'false'
+        run: echo "No relevant changes. Skipping CI." 
+
       - name: Install dependencies
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/yarn-install
       - name: Install Playwright
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: cd packages/twenty-front && npx playwright install
       - name: Front / Restore Storybook Task Cache
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/task-cache
         with:
           tag: scope:frontend
           tasks: storybook:build
       - name: Front / Write .env
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: npx nx reset:env twenty-front
       - name: Run storybook tests
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: npx nx storybook:serve-and-test:static twenty-front --configuration=${{ matrix.storybook_scope }}
   front-sb-test-performance:
-    runs-on: ci-8-cores
-    timeout-minutes: 60
+    timeout-minutes: 30
+    runs-on: shipfox-8vcpu-ubuntu-2204
     env:
       REACT_APP_SERVER_BASE_URL: http://localhost:3000
       NX_REJECT_UNKNOWN_LOCAL_CACHE: 0
     steps:
       - name: Fetch local actions
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Check for changed files
+        id: changed-files
+        uses: tj-actions/changed-files@v11
+        with:
+          files: |
+            packages/twenty-front/**
+
+      - name: Skip if no relevant changes
+        if: steps.changed-files.outputs.any_changed == 'false'
+        run: echo "No relevant changes. Skipping CI."
+
       - name: Install dependencies
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/yarn-install
       - name: Install Playwright
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: cd packages/twenty-front && npx playwright install
       - name: Front / Write .env
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: npx nx reset:env twenty-front
       - name: Run storybook tests
-        run: npx nx storybook:serve-and-test:static:performance twenty-front
+        if: steps.changed-files.outputs.any_changed == 'true'
+        run: npx nx run twenty-front:storybook:serve-and-test:static:performance
   front-chromatic-deployment:
+    timeout-minutes: 30
     if: contains(github.event.pull_request.labels.*.name, 'run-chromatic') || github.event_name == 'push'
     needs: front-sb-build
     runs-on: ubuntu-latest
@@ -123,21 +148,38 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
+
+      - name: Check for changed files
+        id: changed-files
+        uses: tj-actions/changed-files@v11
+        with:
+          files: |
+            packages/twenty-front/**
+
+      - name: Skip if no relevant changes
+        if: steps.changed-files.outputs.any_changed == 'false'
+        run: echo "No relevant changes. Skipping CI."
+
       - name: Install dependencies
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/yarn-install
       - name: Front / Restore Storybook Task Cache
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/task-cache
         with:
           tag: scope:frontend
           tasks: storybook:build
       - name: Front / Write .env
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: |
           cd packages/twenty-front
           touch .env
           echo "REACT_APP_SERVER_BASE_URL: $REACT_APP_SERVER_BASE_URL" >> .env
       - name: Publish to Chromatic
+        if: steps.changed-files.outputs.any_changed == 'true'
         run: npx nx run twenty-front:chromatic:ci
   front-task:
+    timeout-minutes: 30
     runs-on: ubuntu-latest
     env:
       NX_REJECT_UNKNOWN_LOCAL_CACHE: 0
@@ -153,20 +195,35 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
+      - name: Check for changed files
+        id: changed-files
+        uses: tj-actions/changed-files@v11
+        with:
+          files: |
+            packages/twenty-front/**
+
+      - name: Skip if no relevant changes
+        if: steps.changed-files.outputs.any_changed == 'false'
+        run: echo "No relevant changes. Skipping CI."
+
       - name: Install dependencies
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/yarn-install
       - name: Front / Restore ${{ matrix.task }} task cache
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/task-cache
         with:
           tag: scope:frontend
           tasks: ${{ matrix.task }}
       - name: Reset .env
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/nx-affected
         with:
           tag: scope:frontend
           tasks: reset:env
       - name: Run ${{ matrix.task }} task
+        if: steps.changed-files.outputs.any_changed == 'true'
         uses: ./.github/workflows/actions/nx-affected
         with:
           tag: scope:frontend
-          tasks: ${{ matrix.task }}
+          tasks: ${{ matrix.task }}

.github/workflows/ci-release-create.yaml

@@ -15,6 +15,7 @@ on:
 
 jobs:
   create_pr:
+    timeout-minutes: 10
     runs-on: ubuntu-latest
     steps:
       - name: Checkout

.github/workflows/ci-release-merge.yaml

@@ -6,6 +6,7 @@ on:
 
 jobs:
   tag_and_release:
+    timeout-minutes: 10
     runs-on: ubuntu-latest
     if: github.event.pull_request.merged == true && contains(github.event.pull_request.labels.*.name, 'release')
     steps: