Skip to content

Handle task cancellation #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pd95
Copy link
Contributor

@pd95 pd95 commented Feb 7, 2025

AsyncStream cancellation should also cancel the streaming byte buffer of URLSession

AsyncStream cancellation should also cancel the streaming byte buffer of `URLSession`
@pd95
Copy link
Contributor Author

pd95 commented Mar 1, 2025

@kevinhermawan : Could you please review and merge this change?
It is necessary to fix the the continued "AI blabbering" when the user already stopped the generation.

@kevinhermawan
Copy link
Owner

Hi @pd95, sorry for the slow response. I'll merge this PR first and test it in Ollamac.

@kevinhermawan
Copy link
Owner

@pd95 I’m currently busy with academic and work-related matters. Please take on the role of maintainer for both Ollamac and OllamaKit. I trust your ability to handle this task. Let me know if you’re available and willing to take on this responsibility, and I’ll add you as a maintainer. :)

@kevinhermawan kevinhermawan merged commit e41e2f3 into kevinhermawan:main Mar 4, 2025
2 checks passed
@pd95 pd95 deleted the fix/handle-request-cancellation branch March 5, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants