Populate correct meta information in load_file, deprecate taking file objects #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
fix-file-dunder-load-file
branch
2 times, most recently
from
78682e2 to
509295d
Compare
|
closing and opening again to check if that triggers CI |
tmadlener
commented
Apr 30, 2025
tmadlener
force-pushed
the
fix-file-dunder-load-file
branch
from
421636d to
d23279d
Compare
tmadlener
force-pushed
the
fix-file-dunder-load-file
branch
2 times, most recently
from
74b8360 to
3037db5
Compare
tmadlener
commented
Jun 6, 2025
Comment on lines
+105
to
+108
| warnings.warn( | ||
| "load_file will remove support for handling TextIOWrapper. Please switch to pasing os.PathLike", | ||
| FutureWarning, | ||
| ) |
There was a problem hiding this comment.
I am not sure this is used anywhere. It might be possible to remove this entirely and clean the implementation up a bit more.
Only possible if we still have access to the path. If we don't inject this than files that use __file__ will always show up as coming from utils.py >>> print(__file__) >>> <k4fwcore-prefix>/python/k4FWCore/utils.py
Deprecate handling a filehandle
jmcarcell
force-pushed
the
fix-file-dunder-load-file
branch
from
3037db5 to
0d371f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
load_filesets the correct__file__and__spec__information for files that are loaded with itload_fileand always pass a path-like objectENDRELEASENOTES
Setting the correct
__file__is necessary as that is quite frequently used for some special casing, or also to add things tosys.pathrelative to the path of the loaded file, e.g. herePutting out the correct file name was lost in #213
Finally it looks like a simple change in
k4runmakes it trivial to pass in path-like objects rather than open file handles (which we didn't bother to close before).