-
Notifications
You must be signed in to change notification settings - Fork 28
Add the EfficiencyFilter algorithm and tests running it #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@mahmoudali2 can you try to use this for simulating the efficiency? You would need to build k4FWCore with this pull request and then you can run DDPlanarDigi without building since you wouldn't need key4hep/k4Reco#27. This has the advantage that you can know exactly which hits are lost in DDPlanarDigi since you know which hits remain after the efficiency cut. |
1cfdd15
to
99e2faa
Compare
9873265
to
5a18905
Compare
This won't work with the data-model extensions, right? |
5a18905
to
4a0fd50
Compare
Co-authored-by: Andre Sailer <[email protected]>
Co-authored-by: Andre Sailer <[email protected]>
Co-authored-by: Mateusz Jakub Fila <[email protected]>
4a0fd50
to
18df25e
Compare
No, like any algorithm we create here, it can't know about the extensions. It's always the case with any algorithm, no? |
I am wondering whether we can have a somewhat lightweight pseudo plugin mechanism here that makes it possible to add another type list downstream where extensions are defined. OTOH, not having all the functionality for all possible extensions probably also serves as a good incentive for people to actually go use EDM4hep. |
I would argue here that since we have the policy to integrate in EDM4hep new data types only if they have been thoroughly tested, we'd rather provide the needed functionalities to fully integrate extensions into realistic workflows. |
BEGINRELEASENOTES
Exact
parameter can be used to control whether the efficiency is exactly that number of simplyeach element is kept with
Efficiency
probability.Efficiency * length
elements are saved) and in the non-exact versionENDRELEASENOTES
It's also an example of a transformer that works on a single arbitrary collection, of which we didn't have any examples before.
See key4hep/k4Reco#27 (comment)