Create a new target to copy the files after all the other targets #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the python folder is copied to a subdirectory in the build tree and this is used for the python imports. The problem is that Gaudi can overwrite the
__init__.py
with an empty file, and then firstk4run
will complain that the[0]
indexing of the loggers doesn't work, and if that is fixed then it will complain with a weird error.This is the error about the indexing:
which is easy to fix, but then
A way of reproducing it is to build, then comment out one of the files in
k4FWCore/k4FWCore/CMakeLists.txt
Line 33 in 9e0bcb5
and then compile again. The file
k4FWCore/genConfDir/k4FWCore/__init__.py
in the build directory will now be empty, and runningctest
will fail. I have also found these errors consistently in CI one day a few weeks ago (I suspect there is a probability that Gaudi overwrites the file in any build if the order is not the right one).BEGINRELEASENOTES
ENDRELEASENOTES