QukeysConfig: New plugin to allow configuring some aspects of Qukeys #1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gergely Nagy <[email protected]>
The config plugin does only the bare minimum to allow configuring the various timeouts and intervals Qukey makes tweakable. It does no attempt at allowing setting up custom Qukeys. Signed-off-by: Gergely Nagy <[email protected]>
algernon
added
enhancement
Member
|
Since @EvyBongers was asking on Discord, I believe that the state of this PR is "someone needs to test it out and give it a thumbs up" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very bare-bones plugin that lets us configure some aspects of Qukeys (mainly timeouts and intervals and the like) at runtime via Focus, and stores those settings in EEPROM. It does no attempt at making it possible to configure custom Qukeys at this time.
It's a work in progress, but I'm opening the PR to solicit feedback on the direction it's going. There are no docs yet - I'll write those once the code is more solid. I also opted to touch the core Qukeys plugin as little as possible: I only added some getters. The could be a little shorter, and a tiny bit more efficient if we collected the settable things in a struct within Qukeys. We could then make QukeysConfig a friend class of it, and access those settings directly, without having to copy them to a temporary struct. But that'd require more changes to Qukeys itself, and I wanted to avoid the noise at first.