Improve LED indicator timing and priority system for Preonic #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes timing from (1s fade in + 8s flapping + 1s fade out) to (2s fade in + 1s hold + 2s fade out) for cleaner interaction with LED indicators during boot sequence. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Changes: - USB events (global indicators) now always take precedence over Bluetooth events - Added 500ms delay to USB disconnect orange shrink effect - Bluetooth indicators properly wait for USB events to complete before showing - Added showGlobalIndicatorWithDelay() function for delayed global effects - Individual indicators no longer override USB global indicators inappropriately This resolves issues where: 1. Bluetooth indicators would interfere with USB disconnect sequences 2. Bluetooth slots would stay dark during transitions 3. Bluetooth disconnect would override USB connect indicators 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Changes:
- Use dimmer blue color (30% brightness: {0, 0, 76} vs {0, 0, 255})
- Increase duration from 5 seconds to 8 seconds for longer fade
- Creates a more subtle, gentle disconnect indication
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
obra
force-pushed
the
f/nrf52-usb-detect
branch
from
aea1d9e to
9aa7c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
PreonicBootGreeting Timing (1bca5c9)
LED Indicator Priority System (0e11f0b)
showGlobalIndicatorWithDelay()function for delayed global effectsBluetooth Disconnect Animation (083ad74)
{0, 0, 76}vs{0, 0, 255})Issues Resolved
Test Plan
🤖 Generated with Claude Code