Skip to content

Drop support for end-of-life versions of Node.js #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

jonkoops
Copy link
Contributor

Closes #525

@jonkoops jonkoops marked this pull request as ready for review December 13, 2024 14:07
@mposolda
Copy link
Contributor

@jonkoops Thanks! Few questions:

  • Do we want to add support for 23 as well? Looks like keycloak-team discussion agreed with 18, 20 and 22, but if you think that 23 is OK as well, we can go with that. If not, we will need to update default version as well (as this PR set it to 23).

  • Do we want to add supported versions in the official docs file https://github.com/keycloak/keycloak-nodejs-connect/blob/main/guides/securing-apps/nodejs-adapter.adoc rather than to the README? The official docs file would be rendered in the official Keycloak documentation, so that is likely better place for document this?

@jonkoops
Copy link
Contributor Author

Do we want to add support for 23 as well? Looks like keycloak-team discussion agreed with 18, 20 and 22, but if you think that 23 is OK as well, we can go with that. If not, we will need to update default version as well (as this PR set it to 23).

Yes, since this is an actively supported version by the Node.js team so I have added compatibility with that version as well.

Do we want to add supported versions in the official docs file https://github.com/keycloak/keycloak-nodejs-connect/blob/main/guides/securing-apps/nodejs-adapter.adoc rather than to the README? The official docs file would be rendered in the official Keycloak documentation, so that is likely better place for document this?

Yes, I will add this documentation there instead 👍

@jonkoops jonkoops marked this pull request as draft January 23, 2025 11:30
@jonkoops
Copy link
Contributor Author

Putting this PR on hold until we figure out why the tests are taking such a long time to run on CI.

Copy link
Contributor

@rmartinc rmartinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonkoops! LGTM too! And I agree with @mposolda to add the supported versions in a new documentation chapter or paragraph.

@jonkoops jonkoops marked this pull request as ready for review February 3, 2025 08:32
@jonkoops jonkoops merged commit 4b31398 into keycloak:main Feb 3, 2025
5 checks passed
@jonkoops
Copy link
Contributor Author

jonkoops commented Feb 3, 2025

I went ahead and rebased this PR on top of the testing fixes, and now everything passes as expected on newer Node.js versions as well 🎉

@jonkoops jonkoops deleted the eol-node branch February 3, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for end-of-life versions of Node.js
3 participants