Add support for OCI engine #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezekg
force-pushed
the
feature/docker-engine
branch
3 times, most recently
from
49c2e66 to
ba9255f
Compare
ezekg
commented
Nov 9, 2024
ezekg
commented
Nov 10, 2024
ezekg
commented
Nov 10, 2024
| require 'minitar' | ||
| require 'zlib' | ||
|
|
||
| class ProcessDockerImageWorker < BaseWorker |
There was a problem hiding this comment.
This worker should be in a high_memory queue.
ezekg
commented
Nov 10, 2024
ezekg
commented
Nov 10, 2024
ezekg
force-pushed
the
feature/docker-engine
branch
4 times, most recently
from
576478c to
39740c4
Compare
reverts commit 04dabba.
ezekg
force-pushed
the
feature/docker-engine
branch
2 times, most recently
from
7758cb0 to
a4c8292
Compare
ezekg
commented
Nov 15, 2024
app/controllers/api/v1/release_engines/oci/manifests_controller.rb
Outdated
Show resolved
Hide resolved
ezekg
force-pushed
the
feature/docker-engine
branch
from
a4c8292 to
306a26c
Compare
- oci expects any manifest to be referenceable not just the index
ezekg
force-pushed
the
feature/docker-engine
branch
3 times, most recently
from
6967323 to
76844ea
Compare
- eventually add max_upload to plans
- previously, we were treating index.json as a manifest, but in reality it's not really a manifest, even though it uses the same media type as a manifest index, i.e. it's not meant to be served via the /manifests endpoint. in reality, it should really have a media type like application/vnd.oci.layout.index.v1+json. - in addition, layout parsing now supports nested indexes.
ezekg
force-pushed
the
feature/docker-engine
branch
from
76844ea to
88314e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #911. In the end, it should be as simple as building an OCI image layout via
docker buildx build --platform linux/amd64,linux/arm64 -o type=oci,dest=- . > keygen-1.0.0.tarandkeygen upload keygen-1.0.0.tar— the rest should be automatically handled by the OCI engine. Afterwards,docker pull oci.pkg.keygen.sh/keygen/apishould work.Like with npm and friends,
docker pushwill not be supported right away.Prereqs
docker buildx.OCI_TEST_PULL=1).1dockerCLI.orasCLI.skopeoCLI. (With caveat.)Helm compatibility (should be fine?)Can dig into this later.Subreqs
oci.pkg.keygen.shsubdomain.Footnotes
Results from the OCI conformance test can be found here. ↩ ↩2