-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epic: dictionary-based word-breakers 🔬 #12142
base: master
Are you sure you want to change the base?
Conversation
Only wordbreaks anything AFTER the last space / ZWNJ. Doesn't bother with anything before it.
… from unmatched chars in path
…ordbreakers/dict-breaker-start' into change/common/models/wordbreakers/unit-test-trie-access
…/models/wordbreakers/fuse-dict-unmatched-chars
…ordbreakers/dict-breaker-start' into change/common/models/wordbreakers/unit-test-trie-access
…common/models/wordbreakers/fuse-dict-unmatched-chars
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts
|
I got to wondering if there are any "relatively simple" ways to avoid spinning up a WebView to run the model-compiler, should we decide to keep the user-dictionary compilation completely separate from the keyboard. After a bit of searching, I found this: https://github.com/nodejs-mobile - a library for running Node-oriented JS scripts for mobile devices. That said, it'd be a new dependency. |
Other notable thoughts: We should probably not associate a language code with user-dictionary data. That is, we collate the data once and use that with any language supporting predictive-text. My original strategy (as of #11994) was to blend the models into a single, "traversable" model.
@mcdurdin previously suggested instead doing multiple correction-searches and picking the best from among their results after applying relative weighting. This would work, though it would also require support for multiple correction searches that does not yet exist.
|
Data transfer into the webview could be via local file: or http: request. This opens up a number of extensibility questions for KeymanWeb itself and how we could make the web-based experience consistent with the Keyman Android/iOS app experience. |
Co-authored-by: Marc Durdin <[email protected]>
…ers/dict-breaker-start feat(common/models/wordbreakers): begin development of dictionary-based wordbreaking algorithm 🔬
…akers/unit-test-trie-access change(common/models/wordbreakers): allow wordbreaker tests to access TrieModel implementation 🔬
…ers/fuse-dict-unmatched-chars feat(common/models/wordbreakers): fuse adjacent unmatched characters when dictionary-breaking 🔬
…-breaker chore: merge master into dict-breaker 🔬
…-breaker chore: merge master into dict-breaker 🔬
…-breaker chore: merge master into dict-breaker 🔬
…-breaker chore: merge master into dict-breaker 🔬
…-breaker chore: merge master into dict-breaker 🔬
No description provided.