-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Condition shortcut suggestion #46
Conversation
Current PR needs some more details, but I prefer to have you have a look at the overall idea first before I spend more time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So a rml:condition
is a new property of an ExpressionMap, that if it evaluates to true
causes the expression map to produce a result, but if false
causes the expression map to return an empty list.
That in principle sounds good to me.
However, if we use a function execution as value of a condition, one thing that might now cause some problems in the current design of fnml is the separation of rml:functionExecution
and rml:return
on rml:ExpressionMap
. Since rml:condition
is also placed on the same level, this means that we cannot use rml:return
for conditions. That seems like a design issue to me.
Perhaps we can solve this by making the value of a condition an expression map as well?
Some specific comments inline
Yes. I agree and changed accordingly. |
No description provided.