Conversation
|
Current PR needs some more details, but I prefer to have you have a look at the overall idea first before I spend more time |
pmaria
left a comment
There was a problem hiding this comment.
So a rml:condition is a new property of an ExpressionMap, that if it evaluates to true causes the expression map to produce a result, but if false causes the expression map to return an empty list.
That in principle sounds good to me.
However, if we use a function execution as value of a condition, one thing that might now cause some problems in the current design of fnml is the separation of rml:functionExecution and rml:return on rml:ExpressionMap. Since rml:condition is also placed on the same level, this means that we cannot use rml:return for conditions. That seems like a design issue to me.
Perhaps we can solve this by making the value of a condition an expression map as well?
Some specific comments inline
Yes. I agree and changed accordingly. |
No description provided.