Make backends a pointer to avoid copies #11490
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce memory allocations by using pointers to large backend objects. This object is very frequently copied around and is large, resulting in substantial allocation pressure. See pprof -- the big chunk at the left is entirely removed with this change (note: the pprof is obscure due to generics, I promise it is from BackendObjectIR 🙂 )
Change Type
/kind cleanup
Changelog
Additional Notes