Image Registry Inconsistencies #11502
Open
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: suyog shinde <[email protected]>
github-actions
bot
added
do-not-merge/kind-invalid
|
Can anyone help me with this, The labeler is failing |
github-actions
bot
added
kind/fix
github-actions
bot
added
kind/cleanup
yuval-k
reviewed
Jun 28, 2025
| @@ -27,7 +27,7 @@ help: ## Output the self-documenting make targets | |||
| ROOTDIR := $(shell pwd) | |||
| OUTPUT_DIR ?= $(ROOTDIR)/_output | |||
|
|
|||
| export IMAGE_REGISTRY ?= ghcr.io/kgateway-dev | |||
There was a problem hiding this comment.
we need to see if this works for publishing.
we have 2 repos - we push to ghcr.io/kgateway-dev and pull from cr.gateway.dev
There was a problem hiding this comment.
Sure, How can we check that ?
There was a problem hiding this comment.
This is a good start, but we'll need additional changes to make sure it passes in CI. See 85ee04d for an attempt at this from a couple of weeks back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind fix
fix: unify image registry configuration
Motivation:
There was an inconsistency in the image registry configuration across the Helm values, Makefile, and e2e manifests:
install/helm/kgateway/values.yamlused:cr.kgateway.dev/kgateway-devghcr.io/kgateway-devagent-gateway-integration.yamlexplicitly specified:ghcr.io/kgateway-devWhat Changed:
cr.kgateway.dev/kgateway-devas the defaultIMAGE_REGISTRY, aligning with Helm.