trafficpolicy: hash polices for hashing load balancers #11583
+1,186
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: omar <[email protected]>
Signed-off-by: omar <[email protected]>
github-actions
bot
added
do-not-merge/kind-invalid
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for defining and applying HTTP route-level hash policies (for RingHash and Maglev load balancers) via the TrafficPolicy API, wiring them through the CRD, apply-configuration, translator plugins, and integration tests.
- Introduce
HashPoliciesin the TrafficPolicy CRD and apply-configuration types - Implement
hashPolicyForSpecto translate CRD hash policies into EnvoyRouteAction_HashPolicyIR and wire it in the translator and merge logic - Update test utilities and add unit/integration tests for route-level hash policy translation
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| api/v1alpha1/traffic_policy_types.go | Add HashPolicies field to TrafficPolicySpec |
| api/applyconfiguration/api/v1alpha1/trafficpolicyspec.go | Extend apply-configuration to include HashPolicies |
| api/applyconfiguration/utils.go | Register apply-configuration kinds for Cookie, Header, HashPolicy, SourceIP |
| internal/kgateway/extensions2/plugins/trafficpolicy/hash_policy.go | Implement hashPolicyForSpec to build Envoy hash IR |
| internal/kgateway/extensions2/plugins/trafficpolicy/traffic_policy_plugin.go | Wire hash policies into route generation and merging |
| internal/kgateway/extensions2/plugins/trafficpolicy/builder.go | Invoke hashPolicyForSpec in the builder |
| internal/kgateway/translator/gateway/testutils/inputs/loadbalancer/route.yaml | Add sample input for route-level hash policies |
| internal/kgateway/translator/gateway/testutils/outputs/loadbalancer/route.yaml | Add expected Envoy config with hash policies |
| internal/kgateway/translator/gateway/gateway_translator_test.go | Add integration test entry for route-level hash policy |
| internal/kgateway/extensions2/plugins/trafficpolicy/hash_policy_test.go | Unit tests for hashPolicyForSpec |
| install/helm/kgateway-crds/templates/gateway.kgateway.dev_trafficpolicies.yaml | Extend CRD schema for hash policies |
internal/kgateway/extensions2/plugins/trafficpolicy/hash_policy.go
Outdated
Show resolved
Hide resolved
github-actions
bot
added
kind/feature
…shpolicy Signed-off-by: omar <[email protected]>
Signed-off-by: omar <[email protected]>
Signed-off-by: omar <[email protected]>
Signed-off-by: omar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#11457
In order to support hashing load balancers (ring hash and maglev) in BackendConfigPolicy, it is necessary to define the hash policy on the route.
This PR adds options on the TrafficPolicy to configure hash policy on a route. Currently only HTTPRoute as targetRef is supported (Gateway is not supported).
Change Type
/kind new_feature
Changelog
Additional Notes