refactor: Three variables from file.go have been moved to their individual files. #11591
+3
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: devesh <[email protected]>
github-actions
bot
added
do-not-merge/kind-invalid
devc007
changed the title
github-actions
bot
added
kind/cleanup
shashankram
reviewed
Jul 8, 2025
…gested Signed-off-by: devesh <[email protected]>
shashankram
approved these changes
Jul 9, 2025
|
@devc007 please follow the PR description template accurately. Multiple PRs of yours are combining the |
|
@shashankram Thanks for pointing that out! I was a bit confused about the correct change type and changelog earlier, but it’s clear to me now. I’ll make sure to be careful going forward and will update the descriptions in my open PRs. I believe I’ve used the correct labels in this PR—do let me know if anything still needs to be changed. |
timflannagan
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inside file.go, there were three variables — AIValuesManifestPath, InfExtValuesManifestPath, and AgentGatewayIntegrationValuesPath — which were only used in one test file, so I have moved them to their individual files, as suggested in Fixes #11375.
Change Type
Changelog