-
Notifications
You must be signed in to change notification settings - Fork 532
Changed version.required field to true from false. #11592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: devesh <[email protected]>
Signed-off-by: devesh <[email protected]>
Signed-off-by: Devesh chauhan <[email protected]>
.github/workflows/release.yaml
Outdated
elif [[ $GITHUB_REF == refs/tags/* ]]; then | ||
VERSION="${GITHUB_REF#refs/tags/}" | ||
echo "goreleaser_args=--clean" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? This was for the manual version case which is no longer applicable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - I think we can also simplify the conditional on line 55 now that input.version is required:
if [[ ${{ github.event_name }} == 'workflow_dispatch' ]]; then
VERSION="${{ inputs.version }}"
# Validate semver format. Modified version from the recommended semver format.
# See https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string.
if ! echo "$VERSION" | grep -E "^v(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(-((0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(\.(0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(\+([0-9a-zA-Z-]+(\.[0-9a-zA-Z-]+)*))?$" > /dev/null; then
echo "Error: Version '$VERSION' does not match required semver format (e.g., v1.2.3, v2.0.0-alpha.1)"
exit 1
fi
echo "goreleaser_args=--clean --skip=validate" >> $GITHUB_OUTPUT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shashankram @timflannagan thanks for review, I am working on these. will have PR soon.
Signed-off-by: devesh <[email protected]>
af670a3
to
874ae60
Compare
Sorry i had made changes in |
@devc007 Updated version looks good. Can we simplify the conditional outlined in the #11592 (comment)? I think we're good after that to merge 👍 |
Signed-off-by: devesh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Fixes #11552
Change Type
Changelog