Skip to content

Fix XML namespace handling in read of structure-specific SDMX-ML #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 23, 2024
Merged

Fix XML namespace handling in read of structure-specific SDMX-ML #200

merged 8 commits into from
Oct 23, 2024

Conversation

@khaeru
Copy link
Owner

@khaeru khaeru commented Oct 22, 2024 •
edited
Loading

Closes #199.

PR checklist

  • Checks all ✅
  • Update documentation N/A, bug fix
  • Update doc/whatsnew.rst

@khaeru khaeru added bug xml SDMX-ML format reader Read file formats defined by the SDMX standards labels Oct 22, 2024
@khaeru khaeru self-assigned this Oct 22, 2024
khaeru added a commit that referenced this pull request Oct 22, 2024
@khaeru
Add #200 to doc/whatsnew
89829a7
@codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (e88f8d3) to head (293b0c6).
Report is 116 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   98.87%   97.91%   -0.97%     
==========================================
  Files          97       97              
  Lines        7854     7861       +7     
==========================================
- Hits         7766     7697      -69     
- Misses         88      164      +76
Files with missing lines Coverage Δ
sdmx/client.py 93.98% <100.00%> (-3.83%) ⬇️
sdmx/format/xml/common.py 100.00% <100.00%> (ø)
sdmx/reader/json.py 100.00% <100.00%> (ø)
sdmx/reader/xml/common.py 100.00% <100.00%> (ø)
sdmx/reader/xml/v21.py 99.17% <100.00%> (-0.14%) ⬇️
sdmx/testing/__init__.py 99.35% <100.00%> (ø)
sdmx/tests/reader/test_reader_xml_v21.py 100.00% <100.00%> (ø)
sdmx/writer/pandas.py 93.44% <100.00%> (ø)

... and 16 files with indirect coverage changes

@khaeru
Copy link
Owner Author

khaeru commented Oct 22, 2024

@mephinet I have run this with the Gist you provided in #199, and the issue appears to be fixed. Are you able to check any other, ‘real’ code against this branch? If so, I will wait for you to report if the fix also works for that code. If not, I'll go ahead to merge.

@khaeru khaeru mentioned this pull request Oct 22, 2024
Closed
@khaeru khaeru merged commit 70cf79c into main Oct 23, 2024
20 checks passed
@khaeru khaeru deleted the issue/199 branch October 23, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@khaeru khaeru

Labels

bug reader Read file formats defined by the SDMX standards xml SDMX-ML format

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Estat with DSD: XMLParseError on 2nd resource

2 participants

@khaeru