Preserve IdentifiableArtefact(id="") #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@glatterf42 reports that here downstream tests fail with sdmx 2.19.0, but not sdmx 2.18.0.
This happens when an IdentifiableArtefact is initialized with an empty string (
"") as its ID. Previously, this value was preserved. As a consequence of changes in #198, empty string was replaced withMissingID. There was no test covering this case.This PR adds the missing test and a fix.
PR checklist
Update documentationN/A, bugfix