forked from dr-leo/pandaSDMX
-
Notifications
You must be signed in to change notification settings - Fork 22
Adjust expectation for test_request_preview_data() #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+168
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaeru
added a commit
that referenced
this pull request
Jun 17, 2025
khaeru
added a commit
that referenced
this pull request
Jun 17, 2025
Number of keys returned changed from 24 to 30.
khaeru
added a commit
that referenced
this pull request
Jun 17, 2025
khaeru
added a commit
that referenced
this pull request
Jun 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
- Coverage 98.92% 98.09% -0.83%
==========================================
Files 103 103
Lines 8669 8683 +14
==========================================
- Hits 8576 8518 -58
- Misses 93 165 +72
🚀 New features to boost your workflow:
|
- Bump ruff v0.8.3 → v0.11.13, mypy v1.13.0 → 1.16.1. - Satisfy mypy 1.16: - .client: Type hint Client._request_from_url() - .model.v30: add @DataClass to 3 classes inheriting from 2 parent dataclasses - Satisfy ruf v0.11: format test_dataset.py. - Use importlib.util.find_spec() instead of raising ImportError in .util.requests.
Reformat using semantic line breaks.
- Ubuntu 22.04 → 24.04. - Python 3 (unspecified) → 3.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Around 2025-06-09, data returned by the ECB data source changed, causing one test to fail. Compare A versus B. Specifically, series keys returned by the query https://data-api.ecb.europa.eu/service/data/EXR?detail=serieskeysonly changed, such that the number of keys matching a particular filter increased from 24 to 30:
This PR adjusts.
Also:
PR checklist