Skip to content

Conversation

@khaeru
Copy link
Owner

@khaeru khaeru commented Jun 17, 2025

Around 2025-06-09, data returned by the ECB data source changed, causing one test to fail. Compare A versus B. Specifically, series keys returned by the query https://data-api.ecb.europa.eu/service/data/EXR?detail=serieskeysonly changed, such that the number of keys matching a particular filter increased from 24 to 30:

        # A filter can be provided, resulting in fewer keys
        keys = ECB.preview_data("EXR", {"CURRENCY": "CAD+CHF+CNY"})
>       assert len(keys) == 24
E       assert 30 == 24
E        +  where 30 = len([<SeriesKey: FREQ=A, CURRENCY=CAD, CURRENCY_DENOM=EUR, EXR_TYPE=SP00, EXR_SUFFIX=A>, <SeriesKey: FREQ=Q, CURRENCY=CAD, CURRENCY_DENOM=EUR, EXR_TYPE=SP00, EXR_SUFFIX=A>, <SeriesKey: FREQ=H, CURRENCY=CAD, CURRENCY_DENOM=EUR, EXR_TYPE=SP00, EXR_SUFFIX=A>, <SeriesKey: FREQ=M, CURRENCY=CAD, CURRENCY_DENOM=EUR, EXR_TYPE=SP00, EXR_SUFFIX=A>, <SeriesKey: FREQ=D, CURRENCY=CAD, CURRENCY_DENOM=EUR, EXR_TYPE=SP00, EXR_SUFFIX=A>, <SeriesKey: FREQ=Q, CURRENCY=CAD, CURRENCY_DENOM=EUR, EXR_TYPE=BRC0, EXR_SUFFIX=A>, ...])

This PR adjusts.

Also:

PR checklist

  • Checks all ✅
  • Update documentation.
  • Update doc/whatsnew.rst

@khaeru khaeru self-assigned this Jun 17, 2025
@khaeru khaeru added data-source Issues related to specific web services/data source(s) ci labels Jun 17, 2025
@khaeru khaeru force-pushed the fix/ci-2025-w25 branch from 0298ac9 to ffd07f8 Compare June 17, 2025 10:14
khaeru added a commit that referenced this pull request Jun 17, 2025
@khaeru khaeru force-pushed the fix/ci-2025-w25 branch from ffd07f8 to 4dbb86a Compare June 17, 2025 10:20
@khaeru khaeru linked an issue Jun 17, 2025 that may be closed by this pull request
khaeru added a commit that referenced this pull request Jun 17, 2025
@khaeru khaeru force-pushed the fix/ci-2025-w25 branch from 9bfe9ed to bc31c8c Compare June 17, 2025 10:32
Number of keys returned changed from 24 to 30.
khaeru added a commit that referenced this pull request Jun 17, 2025
@khaeru khaeru force-pushed the fix/ci-2025-w25 branch from bc31c8c to ab9ff22 Compare June 17, 2025 10:38
khaeru added a commit that referenced this pull request Jun 17, 2025
@khaeru khaeru force-pushed the fix/ci-2025-w25 branch from ab9ff22 to cc3f253 Compare June 17, 2025 10:45
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.09%. Comparing base (abb42b5) to head (d3cb374).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   98.92%   98.09%   -0.83%     
==========================================
  Files         103      103              
  Lines        8669     8683      +14     
==========================================
- Hits         8576     8518      -58     
- Misses         93      165      +72     
Files with missing lines Coverage Δ
sdmx/client.py 96.17% <100.00%> (-2.74%) ⬇️
sdmx/model/v30.py 100.00% <100.00%> (ø)
sdmx/testing/__init__.py 99.22% <100.00%> (+<0.01%) ⬆️
sdmx/testing/data.py 100.00% <100.00%> (ø)
sdmx/tests/model/test_v21.py 100.00% <100.00%> (ø)
sdmx/tests/test_client.py 100.00% <100.00%> (ø)
sdmx/tests/test_dataset.py 100.00% <100.00%> (ø)
sdmx/tests/test_docs.py 100.00% <100.00%> (ø)
sdmx/util/requests.py 100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

khaeru added 5 commits June 17, 2025 12:52
- Bump ruff v0.8.3 → v0.11.13, mypy v1.13.0 → 1.16.1.
- Satisfy mypy 1.16:
  - .client: Type hint Client._request_from_url()
  - .model.v30: add @DataClass to 3 classes inheriting from 2 parent
     dataclasses
- Satisfy ruf v0.11: format test_dataset.py.
- Use importlib.util.find_spec() instead of raising ImportError in
  .util.requests.
Reformat using semantic line breaks.
- Ubuntu 22.04 → 24.04.
- Python 3 (unspecified) → 3.13.
@khaeru khaeru merged commit f042e75 into main Jun 17, 2025
20 checks passed
@khaeru khaeru deleted the fix/ci-2025-w25 branch June 17, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci data-source Issues related to specific web services/data source(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead link for sdmx information model in readme

2 participants