forked from dr-leo/pandaSDMX
-
Notifications
You must be signed in to change notification settings - Fork 22
Miscellaneous improvements for 2025-W27 #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
249234b to
76aafc0
Compare
76aafc0 to
c2844af
Compare
c2844af to
6b2fe3a
Compare
6b2fe3a to
d0de9f2
Compare
d0de9f2 to
e5c1f83
Compare
e5c1f83 to
dc498c6
Compare
khaeru
added a commit
that referenced
this pull request
Aug 11, 2025
dc498c6 to
b67005c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 98.92% 98.10% -0.83%
==========================================
Files 103 105 +2
Lines 8686 8910 +224
==========================================
+ Hits 8593 8741 +148
- Misses 93 169 +76
🚀 New features to boost your workflow:
|
- Collect logic for comparison of artefacts. - Add tests.
- Remove class-specific .compare() method. - Adjust tests.
- Add Comparable as a parent class where needed.
- Make AnnotableArtefact a subclass of Comparable.
- These and subclasses gain __dataclass_fields__ and can be handled using sdmx.compare. - Make CodingFormat a subclass of Comparable.
b67005c to
78dffe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<reg:SubmitStructureResponse>sdmx.compareto collect logic related to comparing artefacts.PR checklist