Skip to content

Conversation

@khaeru
Copy link
Owner

@khaeru khaeru commented Jun 29, 2025

  • Implement classes related to <reg:SubmitStructureResponse>
    • Write to SDMX-ML.
    • Document implementation.
  • Add sdmx.compare to collect logic related to comparing artefacts.
    • Remove all class-specific compare logic from .message and .model.
    • Expand tests of comparisons.

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru self-assigned this Jun 29, 2025
@khaeru khaeru added enh Enhancements & new features writer Convert objects to other formats xml SDMX-ML format doc Documentation, help, examples, etc. sdmx-3 Support for SDMX 3.0 (2021), 3.1 (2025), etc. labels Jun 29, 2025
@khaeru khaeru marked this pull request as draft June 29, 2025 21:17
@khaeru khaeru force-pushed the enh/submitstructureresponse branch from 249234b to 76aafc0 Compare June 29, 2025 21:53
@khaeru khaeru force-pushed the enh/submitstructureresponse branch from 76aafc0 to c2844af Compare July 16, 2025 12:52
@khaeru khaeru force-pushed the enh/submitstructureresponse branch from c2844af to 6b2fe3a Compare August 5, 2025 17:22
khaeru added a commit that referenced this pull request Aug 11, 2025
@khaeru khaeru force-pushed the enh/submitstructureresponse branch from 6b2fe3a to d0de9f2 Compare August 11, 2025 09:06
khaeru added a commit that referenced this pull request Aug 11, 2025
@khaeru khaeru force-pushed the enh/submitstructureresponse branch from d0de9f2 to e5c1f83 Compare August 11, 2025 09:13
khaeru added a commit that referenced this pull request Aug 11, 2025
@khaeru khaeru force-pushed the enh/submitstructureresponse branch from e5c1f83 to dc498c6 Compare August 11, 2025 09:18
khaeru added a commit that referenced this pull request Aug 11, 2025
khaeru added a commit that referenced this pull request Aug 11, 2025
@khaeru khaeru force-pushed the enh/submitstructureresponse branch from dc498c6 to b67005c Compare August 11, 2025 10:37
@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 99.39940% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.10%. Comparing base (f140e40) to head (78dffe8).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
sdmx/util/__init__.py 90.00% 1 Missing ⚠️
sdmx/writer/xml.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   98.92%   98.10%   -0.83%     
==========================================
  Files         103      105       +2     
  Lines        8686     8910     +224     
==========================================
+ Hits         8593     8741     +148     
- Misses         93      169      +76     
Files with missing lines Coverage Δ
sdmx/compare.py 100.00% <100.00%> (ø)
sdmx/dictlike.py 97.67% <100.00%> (+1.92%) ⬆️
sdmx/format/xml/common.py 100.00% <ø> (ø)
sdmx/message.py 100.00% <100.00%> (ø)
sdmx/model/common.py 99.62% <100.00%> (-0.29%) ⬇️
sdmx/model/v21.py 100.00% <ø> (ø)
sdmx/reader/xml/common.py 100.00% <100.00%> (ø)
sdmx/testing/__init__.py 99.28% <100.00%> (+0.05%) ⬆️
sdmx/tests/model/test_common.py 100.00% <100.00%> (ø)
sdmx/tests/model/test_v21.py 100.00% <100.00%> (ø)
... and 9 more

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

khaeru added 2 commits August 11, 2025 12:56
- Collect logic for comparison of artefacts.
- Add tests.
- Remove class-specific .compare() method.
- Adjust tests.
@khaeru khaeru force-pushed the enh/submitstructureresponse branch from b67005c to 78dffe8 Compare August 11, 2025 10:56
@khaeru khaeru marked this pull request as ready for review August 11, 2025 11:20
@khaeru khaeru merged commit 59a90ec into main Aug 11, 2025
20 checks passed
@khaeru khaeru deleted the enh/submitstructureresponse branch August 11, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Documentation, help, examples, etc. enh Enhancements & new features sdmx-3 Support for SDMX 3.0 (2021), 3.1 (2025), etc. writer Convert objects to other formats xml SDMX-ML format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants