Convert/write SDMX-CSV 2.x #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make .writer.base.BaseWriter a subclass of Converter.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 98.91% 98.24% -0.67%
==========================================
Files 105 113 +8
Lines 8910 9297 +387
==========================================
+ Hits 8813 9134 +321
- Misses 97 163 +66
🚀 New features to boost your workflow:
|
Ensure BaseMetadataSet appears in the MRO before lower-level classes.
- Add enumerations for common and version-specific format parameters. - Add FormatOptions.
- Reimplement .pandas.writer as PandasConverter, a DispatchConverter. - Document conversion options at the class level. - Adjust tests.
- Add Attributes enumeration. - Add format, format_options parameters to PandasConverter. - Separate handling of complex datetime=… parameter to a dedicated method. - Add DATAFLOW column for SDMX-CSV 1.0.
- Don't create an instance of BaseWriter. - Collapse dataset() into the main method. - Drop code for creating DATAFLOW column, now handled by .convert.pandas.
- Ensure Key.copy() returns same type for subclasses.
- Add ColumnSpec to handle column info for conversion.
- Deprecate datetime=…, rtype=… attributes/arguments; add warnings.
- New methods PandasConverter.{get_components,handle_compat,
handle_datetime}().
- Use pandas method chaining and .pipe() functions in convert_dataset().
khaeru
added a commit
that referenced
this pull request
Sep 24, 2025
- Move .writer.pandas docs to new page doc/api/convert.rst. - Move .format docs to new page doc/api/format.rst. - Use consistent page and section titles. - Copyedit descriptive text and cross-link module descriptions.
khaeru
added a commit
that referenced
this pull request
Sep 24, 2025
- Move .writer.pandas docs to new page doc/api/convert.rst. - Move .format docs to new page doc/api/format.rst. - Use consistent page and section titles. - Copyedit descriptive text and cross-link module descriptions.
- Move .writer.pandas docs to new page doc/api/convert.rst. - Move .format docs to new page doc/api/format.rst. - Use consistent page and section titles. - Copyedit descriptive text and cross-link module descriptions.
khaeru
added
writer
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at #242 (comment), this PR adjusts the code layout for conversion to pandas objects and producing SDMX-CSV.
.writer.pandasto.convert.pandas; refactor to reduce complexity..reader.csv. This could later be unified..writer.csv.So making use of the above changes:
PR checklist