Skip to content

Conversation

@khaeru
Copy link
Owner

@khaeru khaeru commented Oct 1, 2025

v2.23.0 triggered errors downstream, e.g. here:

        # Set private attributes
        self._strict = issubclass(
>           self.format_options.format, (csv.v1.FORMAT, csv.v2.FORMAT)
                                         ^^^^^^
        )
E       AttributeError: module 'sdmx.format.csv' has no attribute 'v1'. Did you mean: 'v2'?

.venv/lib/python3.13/site-packages/sdmx/convert/pandas.py:498: AttributeError

h/t @glatterf42 for spotting the issue.

This commit fixes by ensuring the submodules are available as attributes of their parent.

PR checklist

  • Checks all ✅
  • Update documentation Bug fix.
  • Update doc/whatsnew.rst

Prevent AttributeError in .convert.pandas.
@khaeru khaeru self-assigned this Oct 1, 2025
@khaeru khaeru added the bug label Oct 1, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.25%. Comparing base (342dd7d) to head (67cbb17).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   99.02%   98.25%   -0.78%     
==========================================
  Files         114      115       +1     
  Lines        9329     9331       +2     
==========================================
- Hits         9238     9168      -70     
- Misses         91      163      +72     
Files with missing lines Coverage Δ
sdmx/format/csv/__init__.py 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khaeru khaeru merged commit 9520bfb into main Oct 1, 2025
56 of 68 checks passed
@khaeru khaeru deleted the fix/format-csv-import branch October 1, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants