Deal with the parameter handling which was changed in Rails 7.0.6 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 30, 2023 13:56
Since github flow fails to install bundler in Ruby 2.2.
The error message:
Bundler 2 requires Ruby 2.3+, using Bundler 1 on Ruby <= 2.2
/opt/hostedtoolcache/Ruby/2.2.10/x64/bin/gem install bundler -v ~> 1.0
ERROR: While executing gem ... (RuntimeError)
Marshal.load reentered at marshal_load
Took 0.42 seconds
Error: The process '/opt/hostedtoolcache/Ruby/2.2.10/x64/bin/gem' failed with exit code 1
In the test setting Test (MONGOID, 3.1, mongoid_73.gemfile) got this error: SimpleCov failed with exit 1/home/runner/work/pluck_all/pluck_all/test/mongoid/support/seeds.rb:2:in `<top (required)>': uninitialized constant User (NameError)
khiav223577
pushed a commit
to khiav223577/deep_pluck
that referenced
this pull request
Dec 24, 2023
It was fixed in pluck_all, so we update the dependency. See: khiav223577/pluck_all#61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #60
The implementation detail is in khiav223577/rails_compatibility#17
We're extracting the code that is highly likely to be affected by Rails into a separate gem. This allows us to add more test cases and achieve better test coverage.